UiFlow 2.0 discuss(how-to, bug, feature request or sometings)

CAT the Tech

Since update 2.0.9, the buttons on my M5Stack Stick C Plus 2 have been tangled and unusable

The button A and power button (aka button C) are now unresponsive. Their respective callbacks do not get triggered at all.
The button B will trigger the callback for button A!

Here is my test program:

import os, sys, io
import M5
from M5 import *
from hardware import *
import time






def btnA_wasPressed_event(state):
  print('Pressed A')


def btnA_wasReleased_event(state):
  print('Released A')


def btnB_wasPressed_event(state):
  print('Pressed B')


def btnB_wasReleased_event(state):
  print('Released B')


def btnPWR_wasPressed_event(state):
  print('Pressed PWR')


def btnPWR_wasReleased_event(state):
  print('Released PWR')


def setup():

  print('hello M5')
  M5.begin()
  BtnA.setCallback(type=BtnA.CB_TYPE.WAS_PRESSED, cb=btnA_wasPressed_event)
  BtnA.setCallback(type=BtnA.CB_TYPE.WAS_RELEASED, cb=btnA_wasReleased_event)
  BtnB.setCallback(type=BtnB.CB_TYPE.WAS_PRESSED, cb=btnB_wasPressed_event)
  BtnB.setCallback(type=BtnB.CB_TYPE.WAS_RELEASED, cb=btnB_wasReleased_event)
  BtnPWR.setCallback(type=BtnPWR.CB_TYPE.WAS_PRESSED, cb=btnPWR_wasPressed_event)
  BtnPWR.setCallback(type=BtnPWR.CB_TYPE.WAS_RELEASED, cb=btnPWR_wasReleased_event)



def loop():
  M5.update()
  time.sleep_ms(50)


if __name__ == '__main__':
  try:
    setup()
    while True:
      loop()
  except (Exception, KeyboardInterrupt) as e:
    try:
      from utility import print_error_msg
      print_error_msg(e)
    except ImportError:
      print("please update to latest firmware")

All was working well in UiFlow 2.0.8 yesterday, please fix this so I can continue to use it.

CAT the Tech

I also tried some other methods since, none of them had the desired effect:

Method 2 - Pin buttons

This method works only with mode High (pull_low=False), with or without pull
It is incredibly slow to respond (about 1 second)

import os, sys, io
import M5
from M5 import *
from hardware import *
import time



Btn37 = None
Btn39 = None
Btn35 = None


def btn37_wasPressed_event(state):
  global Btn37, Btn39, Btn35
  print('Pressed A')


def btn39_wasPressed_event(state):
  global Btn37, Btn39, Btn35
  print('Pressed B')


def btn35_wasPressed_event(state):
  global Btn37, Btn39, Btn35
  print('Pressed PWR')


def btn35_wasReleased_event(state):
  global Btn37, Btn39, Btn35
  print('Released PWR')


def btn39_wasReleased_event(state):
  global Btn37, Btn39, Btn35
  print('Released B')


def btn37_wasReleased_event(state):
  global Btn37, Btn39, Btn35
  print('Released A')


def setup():
  global Btn37, Btn39, Btn35

  print('hello M5')
  M5.begin()
  # Pin 37 == button A
  # Pin 39 == button B
  # Pin 35 == button PWR (aka button C)
  Btn37 = Button(37, active_low=False, pullup_active=False)
  Btn37.setCallback(type=Btn37.CB_TYPE.WAS_PRESSED, cb=btn37_wasPressed_event)
  Btn37.setCallback(type=Btn37.CB_TYPE.WAS_RELEASED, cb=btn37_wasReleased_event)
  Btn39 = Button(39, active_low=False, pullup_active=False)
  Btn39.setCallback(type=Btn39.CB_TYPE.WAS_PRESSED, cb=btn39_wasPressed_event)
  Btn39.setCallback(type=Btn39.CB_TYPE.WAS_RELEASED, cb=btn39_wasReleased_event)
  Btn35 = Button(35, active_low=False, pullup_active=False)
  Btn35.setCallback(type=Btn35.CB_TYPE.WAS_PRESSED, cb=btn35_wasPressed_event)
  Btn35.setCallback(type=Btn35.CB_TYPE.WAS_RELEASED, cb=btn35_wasReleased_event)


def loop():
  global Btn37, Btn39, Btn35
  M5.update()
  Btn37.tick(None)
  Btn39.tick(None)
  Btn35.tick(None)
  time.sleep_ms(50)


if __name__ == '__main__':
  try:
    setup()
    while True:
      loop()
  except (Exception, KeyboardInterrupt) as e:
    try:
      from utility import print_error_msg
      print_error_msg(e)
    except ImportError:
      print("please update to latest firmware")

Method 3 - machine.Pin (IRQ)

It is fast, responsive
It cannot report accurately if the button was pressed or released if multiple events are queued one after the other

import os, sys, io
import M5
from M5 import *
import time
from hardware import *
from machine import Pin



pin37 = None
pin39 = None
pin35 = None


p = None

# Describe this function...
def button_callback(p):
  global pin37, pin39, pin35
  i = int(str(p)[4:-1])
  print(f"Button id: {i}, value: {p.value()}")


def setup():
  global pin37, pin39, pin35

  print('hello M5')
  M5.begin()
  # Pin 37 == button A
  # Pin 39 == button B
  # Pin 35 == button PWR (aka button C)
  pin37 = Pin(37, mode=Pin.IN)
  pin39 = Pin(39, mode=Pin.IN)
  pin35 = Pin(35, mode=Pin.IN)
  pin37.irq(trigger=Pin.IRQ_RISING | Pin.IRQ_FALLING, handler=button_callback)
  pin39.irq(trigger=Pin.IRQ_RISING | Pin.IRQ_FALLING, handler=button_callback)
  pin35.irq(trigger=Pin.IRQ_RISING | Pin.IRQ_FALLING, handler=button_callback)


def loop():
  global pin37, pin39, pin35
  M5.update()
  time.sleep_ms(50)


if __name__ == '__main__':
  try:
    setup()
    while True:
      loop()
  except (Exception, KeyboardInterrupt) as e:
    try:
      from utility import print_error_msg
      print_error_msg(e)
    except ImportError:
      print("please update to latest firmware")

Edit:
Oh, right, I almost forgot.
There is no such thing as the following in the machine.Pin method:

p.irq().flags()

I don't know if it is because of the micropython port you guys use or if it is the esp32-pico-v3-02's fault, but I think there is something missing there...

lbuque

@CAT-the-Tech I tried running your code and found that it works well.

CAT the Tech

@lbuque Really?
Which method did you use? (1, 2, or 3)
What device are you using?

Thanks

CAT the Tech

Since version 2.1.0, The Pin Buttons method (method 2) does not work AT ALL anymore

lbuque

@CAT-the-Tech stickc_plus2

lbuque

@CAT-the-Tech

cores3 works fine

CAT the Tech

@lbuque Weird...
Can you show me the StickC Plus 2's code you used?
Are you sure your core3 AND StickC Plus 2 are at the latest version? (2.1.0 as of yesterday) (You can see this when it boots, in the terminal)

digiponta

I need it supports M5Stack DIN base with M5 stack/S3.

lbuque

@digiponta said in UiFlow 2.0 discuss(how-to, bug, feature request or sometings):

I need it supports M5Stack DIN base with M5 stack/S3.

DIN base does not require software support, it can be used directly.

CAT the Tech

@lbuque I tried some more ideas to make the buttons work again:

M5 buttons - manual loop

Same results as the original M5 buttons method (button A and PWR (C) won't work no matter what, and button B thinks it is button A)

import os, sys, io
import M5
from M5 import *
from hardware import *
import time






# Describe this function...
def button_check():
  if BtnA.wasPressed():
    print('Pressed A')
  if BtnA.wasReleased():
    print('Released A')
  if BtnB.wasPressed():
    print('Pressed B')
  if BtnB.wasReleased():
    print('Released B')
  if BtnPWR.wasPressed():
    print('Pressed PWR')
  if BtnPWR.wasReleased():
    print('Released PWR')


def setup():

  print('hello M5')
  M5.begin()


def loop():
  M5.update()
  button_check()
  time.sleep_ms(50)


if __name__ == '__main__':
  try:
    setup()
    while True:
      loop()
  except (Exception, KeyboardInterrupt) as e:
    try:
      from utility import print_error_msg
      print_error_msg(e)
    except ImportError:
      print("please update to latest firmware")

Pin buttons - manual loop

Okay, so this one is an absolute monster via blockly (visual editor)

Same results as the original Pin buttons method (it takes some time for the buttons to register the actions and the press/release is inverted))

import os, sys, io
import M5
from M5 import *
from hardware import *
import time



Btn37 = None
Btn39 = None
Btn35 = None


code_str = None
Btn37_last_state = None
Btn39_last_state = None
Btn35_last_state = None

# Describe this function...
def button_check():
  global code_str, Btn37_last_state, Btn39_last_state, Btn35_last_state, Btn37, Btn39, Btn35
  if execute_mpy_code('Btn37.wasPressed()') and not Btn37_last_state:
    print('Pressed A')
    Btn37_last_state = True
  elif execute_mpy_code('Btn37.wasReleased()') and Btn37_last_state:
    print('Released A')
    Btn37_last_state = False
  if execute_mpy_code('Btn39.wasPressed()') and not Btn39_last_state:
    print('Pressed B')
    Btn39_last_state = True
  elif execute_mpy_code('Btn39.wasReleased()') and Btn39_last_state:
    print('Released B')
    Btn39_last_state = False
  if execute_mpy_code('Btn35.wasPressed()') and not Btn35_last_state:
    print('Pressed PWR')
    Btn35_last_state = True
  elif execute_mpy_code('Btn35.wasReleased()') and Btn35_last_state:
    print('Released PWR')
    Btn35_last_state = False

# Describe this function...
def execute_mpy_code(code_str):
  global Btn37_last_state, Btn39_last_state, Btn35_last_state, Btn37, Btn39, Btn35
  return eval(code_str)


def setup():
  global Btn37, Btn39, Btn35, Btn37_last_state, Btn39_last_state, Btn35_last_state

  print('hello M5')
  M5.begin()
  # Pin 37 == button A
  # Pin 39 == button B
  # Pin 35 == button PWR (aka button C)
  Btn37 = Button(37, active_low=False, pullup_active=False)
  Btn39 = Button(39, active_low=False, pullup_active=False)
  Btn35 = Button(35, active_low=False, pullup_active=False)
  Btn37_last_state = False
  Btn39_last_state = False
  Btn35_last_state = False


def loop():
  global Btn37, Btn39, Btn35, Btn37_last_state, Btn39_last_state, Btn35_last_state
  M5.update()
  Btn37.tick(None)
  Btn39.tick(None)
  Btn35.tick(None)
  button_check()
  time.sleep_ms(50)


if __name__ == '__main__':
  try:
    setup()
    while True:
      loop()
  except (Exception, KeyboardInterrupt) as e:
    try:
      from utility import print_error_msg
      print_error_msg(e)
    except ImportError:
      print("please update to latest firmware")

I believe my unit is not the issue, because the machine.Pin method worked as expected (except that I cannot get the state of the button the moment the callback was called)

What are the next steps / things to try?

felmue

Hello @CAT-the-Tech

using M5StickCPlus2 with UIFlow2.1.1 firmware works for me using either Button or Pin Button blocks.

Button blocks example in ProjectZone: M5StickCPlus2_BtnABPWR_Test_UIFlow2.1.1

Pin Button blocks example in PlayZone: M5StickCPlus2_PinButtonTest_UIFlow2.1.1

Note: with Button blocks responds time is much quicker.

Thanks
Felix

CAT the Tech

Hi @felmue ,
Unfortunately, I had the same results with your code as with mine.

The only thing I changed to make your code 'work' is add print statements (I broke my screen, so no more labels for me).
I also had to put the Pin Buttons' init statements to mode=High (otherwise my buttons won't work)

Basically the only difference between your code and mine, other than that, is that you didn't sleep in your loop

I shared my test projects too:
(M5 Buttons) buttons callback test
(pin buttons) buttons callback test
for the pin buttons one, please fill in the callbacks' names to: [37, 37, 39, 39, 35, 35] (there is a bug that whenever you import the project they dissapear)

felmue

Hello @CAT-the-Tech

ok, I think I figured it out. The issue seems to be the broken screen. I get the same results as you do if I remove the screen of my M5StickCPlus2.

UIFlow2 firmware is based on M5Unified (C code) which uses the different screens (or lack thereof) to distinguish between device models. The board ID for M5StickCPlus2 is 5. However without screen it thinks it is an M5Atom (board ID 129). And the M5Atom has a single button connected to GPIO39. That is why pressing BtnB on an M5StickCPlus2 (w/o screen) signals BtnA. See here.

Thanks
Felix

CAT the Tech

@felmue @lbuque Finally! It worked!

As felmue said, it was the broken/unplugged screen that caused my StickCPlus2 to act like a M5Atom
My screen looks to have only the outer plastic/glass layer broken (it still lights on, but it is cracked and only shows lines and stuff).

So I plugged the screen back in, and now the buttons work!

Thank you all for helping me, I will soon order another StickCPlus2 from Mouser.

To the developers:

Can you please make it so that UIFlow2 distinguish between the different models using a model number taken from when M5Burner flashes UIFlow2?

CAT the Tech

Feature requests

An 'Execute mpy code' block that plugs into another block (a value block(?))
The possibility to go back versions in UIFlow2's web interface

Bug/feature request

Normally, when you want to rotate the display, you execute this:

M5.begin()
# M5 inits labels, etc
Widgets.setRotation(1)

But this is wrong! Because it inits the labels BEFORE the screen is rotated, which makes the labels appear once before the screen is rotated, and then stays in the wrong orientation even after the screen is flipped.

What I need to do:

# trick M5  begin
eval("M5" + ".begin()")
Widgets.setRotation(1)
if False:
  M5.begin()
# M5 inits labels, etc

chrol

Hi,

I noticed the THERMAL2Unit name is capitalised wrong in UIFlow 2 web - in the m5stack/unit/init.py it is called "ThermalUnit2" => Import error.
(Even after doing manual codeblock edit I don't get an import error but other errors - but this should likely be fixed anyway)

Thanks
C

chrol

I see that the ThermalUnit2 is now fixed :)

Next issue -

how can I access temperature data buffer and include in REST API or
present it on screen (e.g. do I use it as source for an image UI component somehow?)

Thanks!

@chrol said in UiFlow 2.0 discuss(how-to, bug, feature request or sometings):

Hi,

I noticed the THERMAL2Unit name is capitalised wrong in UIFlow 2 web - in the m5stack/unit/init.py it is called "ThermalUnit2" => Import error.
(Even after doing manual codeblock edit I don't get an import error but other errors - but this should likely be fixed anyway)

Thanks
C

Coopersmith-24601

This post is deleted!

Coopersmith-24601

FEATURE REQUEST!

It would be extraordinarily helpful for there to be a type of LABEL in UiFlow2 which could fill the screen and word-wrap long text strings.